search

code-423n4 / 2023-09-delegate-findings

2 stars 1 forks source link

The code uses assembly for memory allocation, which can be complex and prone to errors. #382

Closed c4-submissions closed 1 year ago

c4-submissions commented 1 year ago

Lines of code

https://github.com/delegatexyz/delegate-registry/blob/6d1254de793ccc40134f9bec0b7cb3d9c3632bc1/src/DelegateRegistry.sol#L444

Vulnerability details

Impact

The code uses assembly for memory allocation, which can be complex and prone to errors. Inefficient memory management can lead to gas inefficiency and potential vulnerabilities.

Proof of Concept

The code uses assembly for memory allocation, which can be challenging to audit and prone to mistakes.

Recommended Mitigation Steps

Consider using higher-level Solidity constructs for memory allocation and management whenever possible. If assembly is necessary for memory operations, thoroughly review and test the code for correctness.

Assessed type

Other

c4-judge commented 1 year ago

GalloDaSballo marked the issue as unsatisfactory: Overinflated severity

GalloDaSballo commented 1 year ago

You can't send this as Med without any proof