search

code-423n4 / 2023-09-reserve-mitigation-findings

0 stars 0 forks source link

M-03 Unmitigated #25

Open c4-submissions opened 1 year ago

c4-submissions commented 1 year ago

Lines of code

https://github.com/reserve-protocol/protocol/blob/master/contracts/plugins/assets/RTokenAsset.sol#L50-L57

Vulnerability details

comments

The issue presents an edge condition which will expand the error of the RToken oracle price. It can come into play when one RToken is using another RToken as collateral either directly or indirectly through an LP token. If there is RSR overcollateralization then this issue is mitigated.

The mitigation only adds some comments and docs to remind developers of this. There is no change in the code for mitigation.

But, IMO, I really agree with the way the development team handled it. I mark it as "unmitigated" just for calling the judge's attention to this no code mitigation.

Assessed type

Context

c4-judge commented 1 year ago

thereksfour marked the issue as satisfactory

c4-judge commented 1 year ago

thereksfour marked the issue as confirmed for report

c4-judge commented 1 year ago

thereksfour marked the issue as not confirmed for report