QA Report

[c4-submissions]

See the markdown file with the details of this report here.

[c4-pre-sort]

bytes032 marked the issue as sufficient quality report

[bytes032]

-57

(require-should-used-instead-of-assert) -3 (burn-functions-must-be-protected-with-a-modifier) -3 (casting-blocktimestamp-can-reduce-the-lifespan-of-a-contract) -3 (code-does-not-follow-the-best-practice-of-check-effects-interaction) TODO (divide-before-multiply) TODO (some-tokens-may-not-consider-typeuint256max-as-an-infinite-approval) -3 (erc20-approve-call-is-not-safe) -3 (empty-uncontrolled-ether-flow-in-receivepayable-fallback) TODO (local-variable-shadowing) TODO (loss-of-precision-in-division-by-large-numbers) TODO (missing-zero-address-validation-in-constructor) TODO (external-calls-in-an-un-bounded-for-loop-may-result-in-a-dos) TODO (payable-function-without-ether-transfer) TODO (potential-division-by-zero) TODO

TODO (safeapprove-deprecated) TODO (setter-no-initial-value-check-detection) TODO (receivepayable-fallback-function-does-not-authorize-requests) TODO (unsafe-cast-unsigned-to-signed) TODO (unsafe-downcast) TODO (approvesafeapprove-without-zero-check) -3 (check-oracle-data-freshness) -3 (missing-sequencer-check) -3 (unchecked-transfer) -3 (calls-transfertransferfrom-with-ierc20) -3 (zero-value-transfers-may-revert) -3 (variables-with-all-caps-names-that-are-not-constants-or-immutables) TODO (avoid-magic-numbers) -3 (cast-to-bytes-or-bytes32-for-clearer-semantic-meaning) TODO (complex-math-in-a-single-line) TODO (improving-code-readability-with-named-mappings ) TODO (consider-using-delete-rather-than-assigning-zerofalse-to-clear-values) TODO (do-not-calculate-constants) TODO (constants-in-comparisons-on-left-side) TODO (constantimmutable-variable-names-should-use-capital-letters-and-underscore) TODO (contract-ordering-violation-style-guide) TODO (control-structures-do-not-follow-the-solidity-style-guide) TODO (costly-operations-inside-a-loop) TODO (dead-code) TODO (avoid-double-casting) TODO (duplicated-requirerevert-checks-should-be-refactored-to-a-modifier-or-function) TODO (else-block-not-required) TODO (events-should-use-parameters-to-convey-information) TODO (function-length-too-long) TODO (lack-of-explicit-visibility-declaration-in-state-variables) TODO (functions-not-called-by-the-contract-should-be-declared-as-external-instead-of-public) TODO (codebase-should-implement-formal-verification-testing) TODO (contracts-should-have-full-test-coverage) TODO (function-names-should-differ) TODO (conformance-to-solidity-function-naming-conventions) TODO (enum-values-should-be-used-in-place-of-constant-array-indexes) TODO (if-statement-can-be-converted-to-a-ternary) TODO (avoid-the-use-of-sensitive-terms) TODO (inconsistency-spacing-in-comments) TODO (inconsistent-usage-of-integer-types) TODO (inconsistent-usage-of-requireerror) TODO (interfaces-should-be-defined-in-separate-files-from-their-usage) TODO (invariant-tests) TODO (lack-of-descriptive-reason-strings-in-requirerevert-statements) TODO (excessive-line-length-in-code) TODO (token-contract-should-have-a-blacklist-function-or-modifier) TODO (contracts-missing-natspec-comments) -3 (missing-events-in-sensitive-functions) TODO (missing-events-arithmetic) TODO (contract-missing-natspec-author) -3 (functions-missing-natspec-comments) -3 (missing-function-parameter-in-natspec-comments) -3 (missing-function-return-values-in-natspec-comments) -3 (contract-missing-natspec-title) -3 (public-variable-declarations-should-have-natspec-descriptions) -3 (events-are-missing-sender-information) TODO (large-numeric-literals-should-use-underscores-for-readability) TODO (consider-move-msgsender-checks-to-modifier) TODO (functions-not-implementing-an-interface) TODO (use-of-old-solidity-version) TODO (override-function-arguments-that-are-unused-should-have-the-variable-name-removed-or-commented-out) TODO (use-return-statement-when-there-is-a-name-return-variable-is-redundant) TODO (event-emission-preceding-external-calls-a-best-practice) TODO (variable-names-too-similar) TODO (constant-redefined-elsewhere) TODO (typo-and-spelling-error) TODO (functions-that-alter-state-should-emit-events) TODO (conformance-to-solidity-struct-naming-conventions) TODO (todo-comments) TODO (too-many-digits) TODO (top-level-declarations-should-be-separated-by-two-blank-lines) TODO (enforce-underscore-prefix-for-non-external-variable-and-function-names) TODO (unnecessary-casting-of-variables) TODO (import-declarations-should-import-specific-identifiers-rather-than-the-whole-file) TODO (unused-function-arguments) TODO (unused-event-definition) TODO (event-is-missing-indexed-fields) TODO (unused-imports) TODO (unused-modifier-definition) TODO (unused-return) TODO (unused-struct-definition) TODO (use-bytesconcat-over-abiencodepacked-for-clearer-semantic-meaning) TODO (use-immutable-for-constant-expressions) TODO (conformance-to-solidity-local-and-state-variable-naming-conventions) TODO (whitespace-in-expressions) TODO (use-of-0-as-a-function-argument) TODO

[c4-pre-sort]

bytes032 marked the issue as insufficient quality report

[c4-judge]

jhsagd76 marked the issue as grade-c