Closed c4-submissions closed 9 months ago
bytes032 marked the issue as insufficient quality report
Disputing, in the event of slashing they can deposit 2 ETH to get 2 stETH or more, so the idea that they cannot is simply incorrect
Allowing smaller sizes of Cdp Size is a potential existential threat to the protocol (see Raft)
Disagree
GalloDaSballo (sponsor) disputed
jhsagd76 marked the issue as unsatisfactory: Out of scope
Lines of code
https://github.com/code-423n4/2023-10-badger/blob/f2f2e2cf9965a1020661d179af46cb49e993cb7e/packages/contracts/contracts/BorrowerOperations.sol#L408
Vulnerability details
Impact
Users below the 2 stETH are unable to save their position or add collateral.
Proof of Concept
Tools Used
Manual Review
Recommended Mitigation Steps
To add a condition where _requireAtLeastMinNetStEthBalance(collateral.getPooledEthByShares(vars.newCollShares)) is not checked only when collateral.getPooledEthByShares(1e18) <= 1e18 and the _adjustCdpInternal has a positive _stEthBalanceIncrease user is trying to add collateral. Bring back a modified condition of the original code https://github.com/ebtc-protocol/ebtc/blob/bd73ac8c0bf7388b9eacc203e6f43b7de38fe42e/packages/contracts/contracts/BorrowerOperations.sol#L326
Assessed type
Other