search

code-423n4 / 2023-10-brahma-findings

8 stars 7 forks source link

Gas Optimizations #435

Open c4-submissions opened 1 year ago

c4-submissions commented 1 year ago

See the markdown file with the details of this report here.

c4-pre-sort commented 1 year ago

raymondfam marked the issue as sufficient quality report

alex-ppg commented 1 year ago

Optimizations of GAS-01 and GAS-04 are slightly incorrect as for 04 the uint32 data type is used to tightly pack the input payload whereas on GAS-01 the subtraction length - 8 - sigLength is potentially unsafe. In any case, I will label it as A for effort as well as partial validity of findings.

c4-judge commented 1 year ago

alex-ppg marked the issue as grade-a

c4-sponsor commented 1 year ago

0xad1onchain (sponsor) acknowledged