QA Report - Githubissues

c4-submissions commented 10 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 10 months ago

raymondfam marked the issue as sufficient quality report

alex-ppg commented 10 months ago

The comparative quality of the report is C as some statements are incorrect.

[L-01] The exhibit is slightly incorrect; a front-running attack vector does not exist as the relevant functions will simply retry until a fresh wallet has been deployed. This is a known concern by the Brahma team based on how the code retries until it succeeds in creating a fresh instance.
[L-02] As elaborated on #15, there does not appear to be any actual harm in permitting EOAs or arbitrary contracts to be registered in the WalletRegistry. It is a valid recommendation nonetheless.
[I-01] I am unsure of what this exhibit entails. The SafeEnabler is necessary as the ModuleManager dependency of a Gnosis Safe expects an external call. During the deployment of a Gnosis Safe, its bytecode is not yet accessible rendering an external self-call impossible to perform. For this purpose, I deem this exhibit incorrect.
[I-02] Valid recommendation.

c4-judge commented 10 months ago

alex-ppg marked the issue as grade-c

code-423n4 / 2023-10-brahma-findings