Gas Optimizations - Githubissues

c4-submissions commented 9 months ago

See the markdown file with the details of this report here.

141345 commented 9 months ago

1558 c3phas
l r nc
4 2 1

G 1 n
G 2 i
G 3 i
G 4 i
G 5 r
G 6 r
G 7 l
G 8 l
G 9 l
G 10 l

c4-pre-sort commented 9 months ago

141345 marked the issue as sufficient quality report

alex-ppg commented 9 months ago

A for now, might be reduced depending on future reports.

Auction Winner Expensive Loop
- Valid gas recommendation and substantial, did not catch #2038
Struct Packing royaltiesPrimarySplits
- Valid recommendation that the bots didn't detect, 1 storage space reduction
Struct Packing royaltiesSecondarySplits
- Valid recommendation that the bots didn't detect, 1 storage space reduction
Struct Packing collectionAdditonalDataStructure
- Valid recommendation that the bots didn't detect, 1 storage space reduction
Constructor Optimization
- Valid but one-off optimization
Zero-to-One Write Avoidance
- Invalid as this applies to instances where the value is toggled between 0 and a non-zero value
Incorrect Caching of MinterContract
- Correct, saves 1 warm SLOAD
Constructor Statement Reordering
- Revert-case optimizations are OOS
Warm SLOAD Optimization in Cancel Bids
- Correct, saves 1 warm SLOAD
SLOAD via Modifier Inlining
- Revert-case optimizations are OOS

c4-judge commented 9 months ago

alex-ppg marked the issue as grade-a

code-423n4 / 2023-10-nextgen-findings