Minting Phases Validation Issue

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-10-nextgen/tree/main/smart-contracts/MinterContract.sol#L172

Vulnerability details

Impact

The minting phases lack proper validation, which can lead to an unfair distribution of tokens. As the public phase is set to be unlimited in duration, the allowlist participants might not have a chance to mint their tokens if the public phase starts before allowlist phase without restriction. This could result in a situation where no tokens are left for the allowlist participants.

Proof of Concept

The root cause of the vulnerability is the lack of proper validation for minting phases, potentially allowing the public phase to start earlier than the allowlist phase.

1. The current setup allows for an unlimited public phase.
2. If there is no proper validation in place, the public phase can start without considering the allowlist participants. All available tokens might run out before the mint phase end.
3. As a result, allowlist participants might not get an opportunity to mint their tokens.
4. This situation is unfair and can lead to dissatisfaction among users.

Tools Used

Manual Review

Recommended Mitigation Steps

To address this issue, it is recommended to implement proper validation for the minting phases. This should include checking time period parameters to ensure that the allowlist phase starts before the public phase.

Assessed type

Invalid Validation

[c4-pre-sort]

141345 marked the issue as insufficient quality report

[c4-pre-sort]

141345 marked the issue as sufficient quality report

[c4-sponsor]

a2rocket (sponsor) disputed

[a2rocket]

as in all projects allowlist users have a specific period to time, allow them to mint after the allowlist phase ended its unfair for other participants on the public phase.

[c4-judge]

alex-ppg marked the issue as duplicate of #588

[c4-judge]

alex-ppg changed the severity to QA (Quality Assurance)

[c4-judge]

alex-ppg marked the issue as grade-c