search

code-423n4 / 2023-10-nextgen-findings

5 stars 3 forks source link

Analysis #2028

Closed c4-submissions closed 7 months ago

c4-submissions commented 7 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 7 months ago

141345 marked the issue as insufficient quality report

alex-ppg commented 7 months ago

The Analysis Report has been graded as C given that it falls in one of the below categories:

c4-judge commented 7 months ago

alex-ppg marked the issue as grade-c

Nabeel-javaid commented 6 months ago

hey, kindly have another look at this analysis report as i've read the comments on the report and I would say that warden have listed all the information that is necessary for the analysis report and have also tried to list some extra info. IDK what do you mean by "vague" cause all the information is strictly in the domain of this project

alex-ppg commented 6 months ago

Hey @Nabeel-javaid, thanks for requesting additional background for this ruling!

I started by compiling a chapter-by-chapter grade of this submission, however, all chapters appear to be insufficient to acquire a grade. All chapters contain boilerplate text / generic that is not strictly applicable to NextGen and can be copy-pasted to apply to any project.

For example, the only NextGen-specific information in Codebase Quality Analysis is the two function names mentioned which do not indicate which contract they stem from.

The Suggestion for Decentralized Governance chapter was provided without any acknowledgment of the current ownership structure of NextGen nor mention of their use of a Gnosis Safe which the Sponsor had provided upon request to multiple other wardens.

The Mechanism Review chapter which is arguably the only NextGen-specific content in the Analysis falls into the Rehash of data present in the documentation of the project as well as its website, and any other such resource category. It offers no newfound insights, and also does not mention all ways an NFT can be minted/burned, such as burnOrSwapExternalToMint.

Based on the above, I maintain the C grade I have assigned for this Analysis. For more information on how Analysis reports should look, kindly consult the grade-A submissions as follows: #2005 #1888 #1841 #1563 #1472 #926 #772