search

code-423n4 / 2023-10-opendollar-findings

10 stars 7 forks source link

failed imports #432

Closed c4-submissions closed 1 year ago

c4-submissions commented 1 year ago

Lines of code

https://github.com/open-dollar/od-contracts/blob/f4f0246bb26277249c1d5afe6201d4d9096e52e6/src/contracts/proxies/Vault721.sol#L4 https://github.com/open-dollar/od-contracts/blob/f4f0246bb26277249c1d5afe6201d4d9096e52e6/src/contracts/proxies/Vault721.sol#L5

Vulnerability details

Impact

Unable to comply correctly

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

manual and slither

Recommended Mitigation Steps

install openzeppelin dependency foundry toml introduce: remappings = ['@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts/'] and import {ERC721} from '@openzeppelin/contracts/token/ERC721/ERC721.sol'; // Vault721.sol::Ln4# incorrect path + Failed import import {ERC721Enumerable} from '@openzeppelin/contracts/token/ERC721/extensions/IERC721Enumerable.sol'

Assessed type

Error

c4-pre-sort commented 1 year ago

raymondfam marked the issue as low quality report

c4-pre-sort commented 1 year ago

raymondfam marked the issue as primary issue

raymondfam commented 1 year ago

Insufficient proof.

c4-judge commented 1 year ago

MiloTruck marked the issue as unsatisfactory: Invalid