search

code-423n4 / 2023-10-opendollar-findings

10 stars 7 forks source link

Upgraded Q -> 2 from #175 [1699029356616] #438

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #175 as 2 risk. The relevant finding follows:

L-02 Initial values for GovernorSettings are very low ODGovernor is a OZ Governor with some plugins. It sets up its parameters in the constructor:

ODGovernor::constructor:

File: src/contracts/gov/ODGovernor.sol

41: GovernorSettings(1, 15, 0) These are in turn, initialVotingDelay=1, initialVotingPeriod=15 and initialProposalThreshold=0.

These values are very low, and initialProposalThreshold=0 can invite to spam. initialVotingPeriod=15 is very short as optimism uses L1 blocks with are just 12 seconds.

I assume these are test chain values, similar to the factories in uniswap and camelot relayers.

Recommendations Do not forget to change these values before going live.

c4-judge commented 1 year ago

MiloTruck marked the issue as duplicate of #202

c4-judge commented 1 year ago

MiloTruck marked the issue as satisfactory