search

code-423n4 / 2023-10-opendollar-findings

10 stars 7 forks source link

Upgraded Q -> 2 from #320 [1699029580772] #441

Closed c4-judge closed 10 months ago

c4-judge commented 10 months ago

Judge has assessed an item in Issue #320 as 2 risk. The relevant finding follows:

  1. The governor setting not reliable The initial setting for the voting period in ODGovernor is 15 block, which can be too tight for the governance. Based on Arbitrum block time, which is about ~0.26 seconds, which can be too short.

    constructor( address _token, TimelockController _timelock ) Governor('ODGovernor') GovernorSettings(1, 15, 0) //@audit voting period too short -> 15 block GovernorVotes(IVotes(_token)) GovernorVotesQuorumFraction(3) GovernorTimelockControl(_timelock) {} Reference: https://officercia.mirror.xyz/d798TVQyA1ALq3qr1R9vvujdF7x-erXxK2wQWwbgRKY

c4-judge commented 10 months ago

MiloTruck marked the issue as duplicate of #202

c4-judge commented 10 months ago

MiloTruck marked the issue as satisfactory