search

code-423n4 / 2023-10-wildcat-findings

14 stars 10 forks source link

check transfer success #625

Closed c4-submissions closed 1 year ago

c4-submissions commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-10-wildcat/blob/main/src/WildcatSanctionsEscrow.sol#L38

Vulnerability details

Impact

Detailed description of the impact of this finding.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Recommended Mitigation Steps

IERC20(asset).transfer(account, amount)

we are not testing the success of this transfer. we should use the call as there is no gas limit of 21000 units.

Recommended Mitigation Steps (success,)= IERC20(asset).transfer(account, amount); require(success,"cannot transfer the amount");

Assessed type

ERC20

c4-pre-sort commented 1 year ago

minhquanym marked the issue as low quality report

minhquanym commented 1 year ago

Invalid

c4-judge commented 1 year ago

MarioPoneder marked the issue as unsatisfactory: Out of scope