search

code-423n4 / 2023-10-wildcat-findings

14 stars 10 forks source link

InterestRate can be changed during close market. #658

Closed c4-submissions closed 1 year ago

c4-submissions commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-10-wildcat/blob/c5df665f0bc2ca5df6f06938d66494b11e7bdada/src/market/WildcatMarketConfig.sol#L149-L159

Vulnerability details

Summary

After closing market, the borrower can set the interest rate.

Impact

Breaking calculations, loss of funds.

Vulnerability Details

After borrower closed the market, he can set interest rate, this means remaining totalSupply still earn interest while it can't be paid.

Tools Used

Manual Review

Recommended Mitigation Steps

Check market status in setAnnualInterest.

Assessed type

Other

c4-pre-sort commented 1 year ago

minhquanym marked the issue as low quality report

c4-pre-sort commented 1 year ago

minhquanym marked the issue as duplicate of #62

c4-pre-sort commented 1 year ago

minhquanym marked the issue as duplicate of #566

c4-judge commented 1 year ago

MarioPoneder marked the issue as unsatisfactory: Insufficient quality