Closed c4-submissions closed 10 months ago
raymondfam marked the issue as insufficient quality report
The description in #62 renders the ratio non-zero always.
raymondfam marked the issue as primary issue
fatherGoose1 marked the issue as unsatisfactory: Invalid
Lines of code
https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/LRTOracle.sol#L78 https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/RSETH.sol#L19
Vulnerability details
Impact
Their can be state where the token is already being used but the depositPool is not used yet and it will cause dos. User under the amount minted will be dosed. The protocol might have to chip in some funds to get the contract in unstuck state.
Proof of Concept
The dos can happen on state where the contracts are deployed and
totalETHInPool =0
butrsETH.totalsupply>0
This can happen in a few ways.rsETH.totalsupply=10e18
User tries to transfers 5 cbETH -> depositPoolit will equal 0 causing a revert
Tools Used
Recommended Mitigation Steps
make sure that the protocol dosnt mint before the contract is deployed
Assessed type
DoS