search

code-423n4 / 2023-11-kelp-findings

13 stars 11 forks source link

Leave space (storage gap) for future developments #253

Closed c4-submissions closed 11 months ago

c4-submissions commented 11 months ago

Lines of code

https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/LRTConfig.sol#L18

Vulnerability details

Impact

Upgradeable contracts must specify storage gap in order for them to be able to support any future state variables.

Proof of Concept

Tools Used

Recommended Mitigation Steps

Implement this, as stated by OpenZeppelin: https://docs.openzeppelin.com/upgrades-plugins/1.x/writing-upgradeable#storage-gaps

Assessed type

Upgradable

c4-pre-sort commented 11 months ago

raymondfam marked the issue as insufficient quality report

c4-pre-sort commented 11 months ago

raymondfam marked the issue as duplicate of #49

c4-judge commented 10 months ago

fatherGoose1 marked the issue as unsatisfactory: Invalid