search

code-423n4 / 2023-11-kelp-findings

13 stars 11 forks source link

check balance provided #483

Open c4-submissions opened 9 months ago

c4-submissions commented 9 months ago

Lines of code

https://github.com/code-423n4/2023-11-kelp/blob/main/src/NodeDelegator.sol#L86

Vulnerability details

Impact

The contract does not check if the amount provided in the transferBackToLRTDepositPool function is less than or equal to the contract's balance of the asset. This could lead to a failed transaction if the contract does not have enough balance of the asset.

Tools Used

Manual

Recommended Mitigation Steps

Assessed type

ERC20

c4-pre-sort commented 9 months ago

raymondfam marked the issue as insufficient quality report

c4-pre-sort commented 9 months ago

raymondfam marked the issue as duplicate of #69

c4-judge commented 9 months ago

fatherGoose1 changed the severity to QA (Quality Assurance)

c4-judge commented 9 months ago

fatherGoose1 marked the issue as grade-b