Upgraded Q -> 2 from #523 [1702572474998]

[c4-judge]

Judge has assessed an item in Issue #523 as 2 risk. The relevant finding follows:

[QA-2] Lack of Array Size Verification in SafeBatchTransferFrom and BalanceOfBatch The safeBatchTransferFrom function does not check if the ids and amounts arrays have the same length before proceeding with the transfer operations.

The balanceOfBatch function assumes that the owners and ids arrays passed as arguments are of equal length without explicit verification.

If the arrays have different lengths, the function may access out-of-bounds indices resulting in unexpected behavior. https://github.com/code-423n4/2023-11-panoptic/blob/aa86461c9d6e60ef75ed5a1fe36a748b952c8666/contracts/tokens/ERC1155Minimal.sol#L128-L191

[QA-3] Lack of ERC1155 standard compliance in SemiFungiblePositionManager contract The SemiFungiblePositionManager contract claims to implement the ERC1155 standard but fails to include the necessary implementation for crucial ERC1155 functions such as safeTransferFrom, safeBatchTransferFrom…

Implement the missing ERC1155 functions in the SemiFungiblePositionManager contract to ensure compliance with the ERC1155 standard https://github.com/code-423n4/2023-11-panoptic/blob/aa86461c9d6e60ef75ed5a1fe36a748b952c8666/contracts/SemiFungiblePositionManager.sol#L72

[c4-judge]

Picodes marked the issue as duplicate of #473

[c4-judge]

This auto-generated issue was withdrawn by Picodes