search

code-423n4 / 2023-11-shellprotocol-findings

7 stars 7 forks source link

QA Report #236

Open c4-bot-2 opened 10 months ago

c4-bot-2 commented 10 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 10 months ago

raymondfam marked the issue as sufficient quality report

0xA5DF commented 10 months ago

[L-01] 2 address tokens will not work properly on the Ocean ERC1155 Ledger.

L

[L-02] Interactions is succeptible to read-only reentrancy

L

[L-03] User can escape fees on ERC1155 tokens

NC

[L-04] Airdrops will be locked in the contract

NC

[N-01] NATSPEC on OceanAdapter._convertDecimals should be revised

L

[N-02] minimumOutputAmount in CurveAdaptor can be integrated into the curve functionalities

R

[N-03] Comments on ERC20Wrap is misleading

NC

0xA5DF commented 10 months ago

+L from #272 +L from #221

c4-judge commented 10 months ago

0xA5DF marked the issue as selected for report