QA Report

[c4-bot-3]

See the markdown file with the details of this report here.

[raymondfam]

Possible upgrade:

L-01 --> #252

[c4-pre-sort]

raymondfam marked the issue as sufficient quality report

[c4-sponsor]

viraj124 (sponsor) acknowledged

[0xA5DF]

[L-01] Potential Overcharge on Unwrapping Fee

L

[L-02] Incorrect Event Parameter in Swap Action

R

[L-03] Incorrect Documentation Regarding int256 Maximum Value

I

[L-04] Unnecessary Fallback Function

R

[L-05] Missing Sender Address Check

L

[N-01] slippageProtection type and naming

R

[N-02] Inconsistent Accounting of ETH Wrapping as Interactions

R

[N-03] Potential Revert in _getNegativeBalanceDelta Function

NC

[N-04] Misleading Function Name in Curve2PoolAdapter Contracts

I

[N-05] Misleading Variable Name

NC

[N-01] Inconsistent Variable Naming for IDs

NC

[0xA5DF]

Side note: regarding layout I'd recommend adding a direct link to the relevant code (including line number), this way it's easier to see the context of the finding

[0xA5DF]

+1 low from #299

[c4-judge]

0xA5DF marked the issue as grade-a