Upgraded Q -> 2 from #236 [1702712918238]

[c4-judge]

Judge has assessed an item in Issue #236 as 2 risk. The relevant finding follows:

[N-01] NATSPEC on OceanAdapter._convertDecimals should be revised

The function _convertDecimals() from OceanAdapter.sol is an exact copy on Ocean.sol. However, OceanAdapter version does not return the truncated amount.

(OceanAdapter.sol)
function _convertDecimals(
        uint8 decimalsFrom,
        uint8 decimalsTo,
        uint256 amountToConvert
    )
        internal
        pure
>       returns (uint256 convertedAmount)

 function _convertDecimals(
        uint8 decimalsFrom,
        uint8 decimalsTo,
        uint256 amountToConvert
    )
        internal
        pure
>       returns (uint256 convertedAmount, uint256 truncatedAmount)

The comments on OceanAdapter.sol should be revised accordingly to not reference the truncatedAmount.

     * @dev convert a uint256 from one fixed point decimal basis to another,
     *   returning the truncated amount if a truncation occurs.

https://github.com/code-423n4/2023-11-shellprotocol/blob/485de7383cdf88284ee6bcf2926fb7c19e9fb257/src/adapters/OceanAdapter.sol#L129-L130

[c4-judge]

0xA5DF marked the issue as duplicate of #252

[c4-judge]

0xA5DF marked the issue as partial-50

[0xA5DF]

Partial credit for not fully identifying the impact

[c4-judge]

0xA5DF marked the issue as partial-25

[c4-judge]

This auto-generated issue was withdrawn by 0xA5DF

[c4-judge]

0xA5DF marked the issue as grade-c

[0xA5DF]

Moved back to #236