code-423n4 / 2023-12-autonolas-findings

3 stars 3 forks source link

Gas Optimizations #369

Open c4-bot-8 opened 10 months ago

c4-bot-8 commented 10 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 10 months ago

alex-ppg marked the issue as sufficient quality report

c4-judge commented 9 months ago

dmvt marked the issue as grade-b

thenua3bhai commented 9 months ago

Hi @dmvt Thanks for Judging. I would like to say that my report contains 3 major finidngs G-01, G-02 and G-03 since they save storage slots. Which is very important in gas reports to save Gsset(20000 Gas) on first time setting and first access in each transaction(Gcoldsload - 2100 gas) saves 2000 gas since warm access take only 100 Gas. They receives a L score on each in previous reports which is of 5 point for each. Along with this it contains 12 more findings also which can be considered r/nc type from all the in scope code. So I think grade-b is bit harsh for this, grade-a will be more suitable for this. So I want you to please re-evaluate this gas report.
Thanks

dmvt commented 9 months ago

When grading gas reports, I ignore reports without the amount of gas saved stated. As such, you have 2, maybe 3, valid findings, making this a grade B on the curve vs other reports submitted in this contest.