code-423n4 / 2023-12-autonolas-findings

3 stars 3 forks source link

Analysis #387

Open c4-bot-1 opened 9 months ago

c4-bot-1 commented 9 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 9 months ago

alex-ppg marked the issue as sufficient quality report

c4-judge commented 8 months ago

dmvt marked the issue as grade-b

pavankv241 commented 8 months ago

Hi there , @dmvt Thank you for taking the time to evaluate our report. I would like to point out that our report includes recommendations, valuable systematic risks, and added value for sponsors. I would like to highlight the 6th recommendation which is officially mentioned in UNISWAP v2 docs and it is not provided in any of the A-graded report but has been implemented in the ongoing contest on C4. You can find more information about it in the following link. Our systematic risks and recommendations are pointing-out and identified for specific code; sponsors don't need any additional info, which definitely adds value for sponsors. I'm requesting that you re-evaluate our report and our report holds more than grade-b. i would like hear words from your side.

dmvt commented 8 months ago

Noted. Your report did seem reasonably detailed, but I didn't give a lot of time or consideration to it due to the general lack of time and consideration you've given to providing other vulnerabilities. Analysis is a great addon when a warden takes time to focus on the core goal, which is finding impactful issues of value to the sponsor.

pavankv241 commented 8 months ago

Thanks for your comment and time @dmvt. I understand the importance of time and consideration, and I agree with the issue you've opened 142. I would like to highlight the following points, apart from the contract protocol overview:

Recommendation:

Other recommendations will suggest the implementation of a new architecture that safeguards the protocol from risks, enhances transparency, and helps build the integration between users and the protocol.

I hope our report holds more than grade-b and met the criteria mention in C4 docs Verdict: Severity Standardization - Centralization risks and expert analysis on Verdict-judging-analysis-submissions.

Happy with your further actions.