search

code-423n4 / 2023-12-autonolas-findings

3 stars 3 forks source link

claimOwnerIncentives x depositServiceDonationsETH x checkpoint x-entrancy Attack to get instant topups #455

Closed c4-bot-7 closed 8 months ago

c4-bot-7 commented 9 months ago

Lines of code

https://github.com/code-423n4/2023-12-autonolas/blob/2a095eb1f8359be349d23af67089795fb0be4ed1/tokenomics/contracts/Treasury.sol#L406https://github.com/code-423n4/2023-12-autonolas/blob/2a095eb1f8359be349d23af67089795fb0be4ed1/tokenomics/contracts/Treasury.sol#L257 https://github.com/code-423n4/2023-12-autonolas/blob/2a095eb1f8359be349d23af67089795fb0be4ed1/tokenomics/contracts/Dispenser.sol#L104 https://github.com/code-423n4/2023-12-autonolas/blob/2a095eb1f8359be349d23af67089795fb0be4ed1/tokenomics/contracts/Treasury.sol#L298 https://github.com/code-423n4/2023-12-autonolas/blob/2a095eb1f8359be349d23af67089795fb0be4ed1/tokenomics/contracts/Tokenomics.sol#L1067

Vulnerability details

Impact

Double Topup via claimOwnerIncentives-> depositServiceDonationsETH -> checkpoint -> claimOwnerIncentives loop

Proof of Concept

-> Deploys Attacking Smart Contract -> Executes 1st transaction via Attacking Contract to trigger depositServiceDonationsETH -> Execute 2nd transaction via Attacking Contract to trigger:

Tools Used

Manual review

Recommended Mitigation Steps

Add x entrancy checks

Assessed type

Reentrancy

c4-pre-sort commented 9 months ago

alex-ppg marked the issue as insufficient quality report

c4-judge commented 8 months ago

dmvt marked the issue as unsatisfactory: Insufficient proof

c4-judge commented 8 months ago

dmvt marked the issue as unsatisfactory: Overinflated severity