search

code-423n4 / 2023-12-ethereumcreditguild-findings

17 stars 11 forks source link

QA Report #1136

Open c4-bot-7 opened 9 months ago

c4-bot-7 commented 9 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 9 months ago

0xSorryNotSorry marked the issue as sufficient quality report

Trumpero commented 8 months ago

There is no check whether a LendingTerm has received enough weight -> low

No one will have the initiative to call forgive() in AuctionHouse.sol -> info

The second phase of the auction does not include the last block -> NC, since creditAsked in else if block will still be 0

Trumpero commented 8 months ago

+L from https://github.com/code-423n4/2023-12-ethereumcreditguild-findings/issues/739 +L from https://github.com/code-423n4/2023-12-ethereumcreditguild-findings/issues/698 +L from https://github.com/code-423n4/2023-12-ethereumcreditguild-findings/issues/696 +L from https://github.com/code-423n4/2023-12-ethereumcreditguild-findings/issues/687

c4-judge commented 8 months ago

Trumpero marked the issue as grade-b