search

code-423n4 / 2023-12-ethereumcreditguild-findings

17 stars 11 forks source link

Upgraded Q -> 2 from #332 [1706646042460] #1279

Closed c4-judge closed 8 months ago

c4-judge commented 8 months ago

Judge has assessed an item in Issue #332 as 2 risk. The relevant finding follows:

params.maxDelayBetweenPartialRepay should never be zero

In LendingTerm.partialRepayDelayPassed, the code makes it return false if maxDelayBetweenPartialRepay is set to 0, which stands to reason. However, due to this, that value will prevent anyone from calling an underwater loan, unless the entire gauge gets deprecated, which seems pretty drastic. We recommend never to allow this parameter to be zero, considering how easy it is to get bad debt and require the gauge to be deprecated.

c4-judge commented 8 months ago

Trumpero marked the issue as duplicate of #1057

Trumpero commented 8 months ago

This issue should receive only 50% partial credit due to its lack of quality.

c4-judge commented 8 months ago

Trumpero marked the issue as partial-50