search

code-423n4 / 2023-12-ethereumcreditguild-findings

9 stars 5 forks source link

Upgraded Q -> 2 from #808 [1706659262817] #1286

Closed c4-judge closed 5 months ago

c4-judge commented 5 months ago

Judge has assessed an item in Issue #808 as 2 risk. The relevant finding follows:

[L‑01] claimRewards() could be reverted due to Out Of GAS

There's a possibility of SurplusGuildMinter#getRewards() failing due to running out of gas, caused by ProfitManager#claimRewards() because there's no maximum gauge limitation on SurplusGuildMinter. (canExceedMaxGauges for SurplusGuildMinter is set to true in deployment scripts)

To mitigate this, consider using ProfitManager#claimGaugeRewards() instead:

-       ProfitManager(profitManager).claimRewards(address(this)); // this will update profit indexes
+       ProfitManager(profitManager).claimGaugeRewards(address(this), term);
c4-judge commented 5 months ago

Trumpero marked the issue as duplicate of #69

c4-judge commented 5 months ago

Trumpero marked the issue as partial-50

piken commented 4 months ago

Thanks for upgrading this issue to med!

I would like to know the reason why it was marked as partial-50. Very appreciate if you can reply this and let me learn some rules from this judging.

Trumpero commented 4 months ago

@piken You can refer the docs of partial scoring here. This issue lacks the quality needed to receive more credits.