search

code-423n4 / 2023-12-ethereumcreditguild-findings

9 stars 5 forks source link

Upgraded Q -> 2 from #1212 [1706668026325] #1288

Closed c4-judge closed 5 months ago

c4-judge commented 5 months ago

Judge has assessed an item in Issue #1212 as 2 risk. The relevant finding follows:

2. _partialRepay in LendingTerm.sol does not support 0 interest loans

The function _partialRepay is used to make partial repayments of a loan. The issue is that during repayment, the interestRepaid is always required to be above 0.

uint256 interestRepaid = debtToRepay - principalRepaid;
require(
    principalRepaid != 0 && interestRepaid != 0,
    "LendingTerm: repay too small"
);
c4-judge commented 5 months ago

Trumpero marked the issue as duplicate of #756

Trumpero commented 5 months ago

This issue should receive only 50% partial credit due to its lack of quality

c4-judge commented 5 months ago

Trumpero marked the issue as partial-50