code-423n4 / 2024-01-curves-findings

1 stars 0 forks source link

Missing constructor for Ownable in CurvesERC20.sol #1483

Closed c4-bot-8 closed 10 months ago

c4-bot-8 commented 10 months ago

Lines of code

https://github.com/code-423n4/2024-01-curves/blob/main/contracts/CurvesERC20.sol#L8

Vulnerability details

Impact

There is no constructor set up for Ownable, CurvesERC20 can't be deployed as there will be an error for this issue

Tools Used

Manual Review

Recommended Mitigation Steps

replace transferOwnership(owner) with Ownable(owner) as OpenZeppelin Wizard suggests:

    constructor(string memory name_, string memory symbol_, address owner) ERC20(name_, symbol_) + Ownable(owner){
-        transferOwnership(owner); //@audit wrong constructor for ownable
    }

Assessed type

Other

c4-pre-sort commented 10 months ago

raymondfam marked the issue as insufficient quality report

c4-pre-sort commented 10 months ago

raymondfam marked the issue as duplicate of #67

c4-judge commented 10 months ago

alcueca marked the issue as unsatisfactory: Invalid