code-423n4 / 2024-01-decent-findings

3 stars 3 forks source link

Analysis #617

Open c4-bot-7 opened 7 months ago

c4-bot-7 commented 7 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 7 months ago

raymondfam marked the issue as high quality report

c4-sponsor commented 6 months ago

wkantaros (sponsor) acknowledged

c4-judge commented 6 months ago

alex-ppg marked the issue as grade-b

ihtisham-sudo commented 6 months ago

I considered this analysis should be marked as Grade-A instead of Grade-B.I provided most of the context through diagrams and tried to make it as precise as possible and included all the important considerations, improvements that the protocol needs to. I could've extended this report by providing context in diagrams, I Put, in textual form but I don't believe as it would provide any quality by extending analysis report through repetition of same thing or using boiler plate or AI. As one or two A graded Analysis Report even have used Diagrams and contracts information extracted from 'Solidity Metrics' Extension just to extend the Analysis Report that could easily be achieved by Developers at Decent with just a vs-code extension. I want you to have a look at it again. Thanks @alex-ppg

alex-ppg commented 6 months ago

Hey @ihtisham-sudo, thank you for your contribution. I have reconsidered this particular case and will retain my grade-b judgment as the report is relatively lackluster in comparison to others. To note, Analysis reports do not necessarily need to have diagrams and thus investing extensive effort in making new ones is not necessarily a good thing for the final grade of the report.