Closed c4-bot-7 closed 10 months ago
https://github.com/re-nft/smart-contracts/blob/3ddd32455a849c3c6dc3c3aad7a33a6c9b44c291/src/Kernel.sol#L548
Detailed description of the impact of this finding. The return value of an external call is not stored in a local or state variable.
Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
for (uint256 i; i < depLength; ++i) { // Reconfigure its dependencies. dependents[i].configureDependencies(); }
function configureDependencies() external virtual onlyKernel returns (Keycode[] memory dependencies) {}
Ensure that all the return values of the function calls are used.
Context
141345 marked the issue as sufficient quality report
141345 marked the issue as insufficient quality report
0xean marked the issue as unsatisfactory: Insufficient quality
Lines of code
https://github.com/re-nft/smart-contracts/blob/3ddd32455a849c3c6dc3c3aad7a33a6c9b44c291/src/Kernel.sol#L548
Vulnerability details
Impact
Detailed description of the impact of this finding. The return value of an external call is not stored in a local or state variable.
Proof of Concept
Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
for (uint256 i; i < depLength; ++i) { // Reconfigure its dependencies. dependents[i].configureDependencies(); }
function configureDependencies() external virtual onlyKernel returns (Keycode[] memory dependencies) {}
Tools Used
Recommended Mitigation Steps
Ensure that all the return values of the function calls are used.
Assessed type
Context