Upgraded Q -> 2 from #878 [1709061118939]

c4-judge commented 4 months ago

Judge has assessed an item in Issue #878 as 2 risk. The relevant finding follows:

[L-02] typo in Pools.removeLiquidity File: https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/pools/Pools.sol#L187 In Pools.sol#L187, the currect check should be:

diff --git a/src/pools/Pools.sol b/src/pools/Pools.sol index 7adb563..1fd3f3e 100644 --- a/src/pools/Pools.sol +++ b/src/pools/Pools.sol @@ -184,7 +184,7 @@ contract Pools is IPools, ReentrancyGuard, PoolStats, ArbitrageSearch, Ownable

            // Make sure that removing liquidity doesn't drive either of the reserves below DUST.
            // This is to ensure that ratios remain relatively constant even after a maximum withdrawal.

require((reserves.reserve0 >= PoolUtils.DUST) && (reserves.reserve0 >= PoolUtils.DUST), "Insufficient reserves after liquidity removal");

require((reserves.reserve0 >= PoolUtils.DUST) && (reserves.reserve1 >= PoolUtils.DUST), "Insufficient reserves after liquidity removal");

        // Switch reclaimed amounts back to the order that was specified in the call arguments so they make sense to the caller
        if (flipped)

c4-judge commented 4 months ago

Picodes marked the issue as duplicate of #784

c4-judge commented 4 months ago

Picodes marked the issue as satisfactory

code-423n4 / 2024-01-salty-findings

Upgraded Q -> 2 from #878 [1709061118939] #1063