Upkeep._formPOL() calls pools.depositSwapWithdraw with no allowance for slippage. If the zero slippage requirement is not met then the function will revert .This could be caused in a situation where the liquidity pool exists but does not allow for zero slippage with the assets it is holding.
Lines of code
https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/Upkeep.sol#L132-L133
Vulnerability details
Impact
Upkeep._formPOL()
callspools.depositSwapWithdraw
with no allowance for slippage. If the zero slippage requirement is not met then the function will revert .This could be caused in a situation where the liquidity pool exists but does not allow for zero slippage with the assets it is holding.Proof of Concept
Tools Used
Manual
Recommended Mitigation Steps
add an input parameter to the function to handle a slippage allowance.
Assessed type
Other