Open c4-bot-1 opened 7 months ago
Picodes marked the issue as primary issue
othernet-global (sponsor) acknowledged
Note: the overcollateralized stablecoin mechanism has been removed from the DEX.
https://github.com/othernet-global/salty-io/commit/f3ff64a21449feb60a60c0d60721cfe2c24151c1
Note: the overcollateralized stablecoin mechanism has been removed from the DEX.
https://github.com/othernet-global/salty-io/commit/f3ff64a21449feb60a60c0d60721cfe2c24151c1
Picodes marked the issue as satisfactory
Picodes changed the severity to 2 (Med Risk)
Picodes marked the issue as selected for report
Regrouping as duplicates of this issue reports about the fact that the swaps are not atomic so the protocol holds a temporary change risk.
The stablecoin framework: /stablecoin, /price_feed, WBTC/WETH collateral, PriceAggregator, price feeds and USDS have been removed: https://github.com/othernet-global/salty-io/commit/88b7fd1f3f5e037a155424a85275efd79f3e9bf9
Lines of code
https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/Upkeep.sol#L244 https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/stable/CollateralAndLiquidity.sol#L140
Vulnerability details
Impact
Proof of Concept
Tools Used
Manual review
Recommended Mitigation Steps
sell assets and acquire USDS on external market
and just likeliquidateUser()
andperformUpkeep()
, reward the users for doing it (calling the function).Assessed type
Other