search

code-423n4 / 2024-01-salty-findings

11 stars 6 forks source link

QA Report #907

Open c4-bot-2 opened 7 months ago

c4-bot-2 commented 7 months ago

See the markdown file with the details of this report here.

c4-judge commented 7 months ago

Picodes marked the issue as grade-a

c4-sponsor commented 6 months ago

othernet-global (sponsor) acknowledged

cryptostaker2 commented 6 months ago

Hi Picodes,

I believe [L-08] is a duplicate of #632, which talks about how WBTC is not 1:1 to BTC.

[L-09] is a duplicate of #938, which talks about how the different price oracles does not show the precise price feed, leading to complications.

[L-10] is a duplicate of #905, which talks about how USDS may depeg due to extreme market volatility.

Thanks for reviewing!

Picodes commented 6 months ago

@cryptostaker2 thanks for your comment.

I do agree with you about L-08 and have corrected it accordingly.

For L-09 the main issue is that one of the 3 prices is manipulatable which isn't discussed here.

For L-10 I don't see how it's a duplicate. This report discusses the risk of the protocol while #905 is about the fact that the DAO holds a temporary change risk that is left unhedged.