search

code-423n4 / 2024-01-salty-findings

11 stars 6 forks source link

QA Report #913

Open c4-bot-7 opened 7 months ago

c4-bot-7 commented 7 months ago

See the markdown file with the details of this report here.

c4-judge commented 7 months ago

Picodes marked the issue as grade-a

c4-judge commented 7 months ago

Picodes marked the issue as selected for report

c4-sponsor commented 6 months ago

othernet-global (sponsor) confirmed

othernet-global commented 6 months ago

L1: Comment will be updated to "Make sure that the reserves after swap are at least DUST"

L2. Actual addedLiquidity will be checked against DUST.

L3. Will fix.

L4. Will fix.

L5. Will fix.

L6. Will fix.

L7. Acceptable as proposals cannot be made for 45 days after launch, and staked SALT will be higher than 49.

L8. Acceptable as an adjustment will be made to reset the emissions timestamp on approval of the BootstrapBallot and performUpkeep will be called frequently.

othernet-global commented 6 months ago

L2: addLiquidity now requires addedAmount0 and addedAmount1 to be greater than DUST. Fixed in: https://github.com/othernet-global/salty-io/commit/0bb763cc67e6a30a97d8b157f7e5954692b3dd68

othernet-global commented 6 months ago

L-01 fixed: https://github.com/othernet-global/salty-io/commit/7d61857dd021ac4c549d062a49c83629c2d7d741

othernet-global commented 6 months ago

L-03-L06: Country and text validation added

https://github.com/othernet-global/salty-io/commit/ace526b48930081ab46cdb017759117546e24e25

c4-judge commented 6 months ago

Picodes marked the issue as not selected for report

Picodes commented 6 months ago

2nd best report after https://github.com/code-423n4/2024-01-salty-findings/issues/638 for me