search

code-423n4 / 2024-01-salty-findings

4 stars 3 forks source link

QA Report #918

Open c4-bot-7 opened 5 months ago

c4-bot-7 commented 5 months ago

See the markdown file with the details of this report here.

c4-judge commented 5 months ago

Picodes marked the issue as grade-a

c4-sponsor commented 4 months ago

othernet-global (sponsor) acknowledged

othernet-global commented 4 months ago

L1: It is acceptable to allow voting until the ballot is finalized.

L2: Comment will be updated.

L3: Acceptable.

L4: _addLiquidity is an internal function and addLiquidity makes the following checks: require( maxAmountA > PoolUtils.DUST, "The amount of tokenA to add is too small" ); require( maxAmountB > PoolUtils.DUST, "The amount of tokenB to add is too small" );

L5: Yes, this is acceptable. The comment will be updated:

// Returns the unstakeIDs for the user function userUnstakeIDs( address user ) external view returns (uint256[] memory)

L6: Will be done.

L7: Acknowledged

L8: Scaling will be removed

othernet-global commented 4 months ago

Low-02 fixed: https://github.com/othernet-global/salty-io/commit/7d61857dd021ac4c549d062a49c83629c2d7d741