search

code-423n4 / 2024-01-salty-findings

4 stars 3 forks source link

tokens transfer fees. #988

Closed c4-bot-7 closed 5 months ago

c4-bot-7 commented 5 months ago

Lines of code

https://github.com/code-423n4/2024-01-salty/blob/main/src/pools/Pools.sol#L283

Vulnerability details

Impact

Detailed description of the impact of this finding.

The contract assumes that tokens do not have transfer fees. If a token with transfer fees is used, it could disrupt the balance calculations.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Tools Used

Recommended Mitigation Steps

we should keep in mind tokens with transfer fees.

Assessed type

Context

c4-judge commented 5 months ago

Picodes marked the issue as unsatisfactory: Out of scope