code-423n4 2024-01-salty-findings issues

code-423n4 / 2024-01-salty-findings

11 stars 6 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Users can DOS the whitelist process

#866 c4-bot-6 closed 7 months ago
2
A malicious user can receive more liquidity rewards than usual.

#865 c4-bot-5 closed 7 months ago
2
Pending amount of SALT-token is not collected from liquidityRewardsEmitter when unwhitelisting pool.

#864 c4-bot-1 closed 7 months ago
2
QA Report

#863 c4-bot-1 opened 7 months ago
1
Timelock can be bypass

#862 c4-bot-7 closed 7 months ago
2
setContracts can be called multiple times.

#861 c4-bot-10 closed 7 months ago
2
No arrangement for when exchange does not start on first voting attempt.

#860 c4-bot-3 closed 7 months ago
2
Gas Optimizations

#859 c4-bot-3 closed 7 months ago
1
`CollateralAndLiquidity.userCollateralValueInUSD` uses the wrong algorithm to calcuate user's collateral value.

#858 c4-bot-5 closed 7 months ago
6
Gas Optimizations

#857 c4-bot-1 closed 7 months ago
1
The exchange may not start up, due to incorrect logic handling

#856 c4-bot-3 closed 7 months ago
2
DoS Vulnerability in `Proposals::proposeSendSALT` and ` Proposals::proposeSetContractAddress` by Users with `requiredXSalt` Balance

#855 c4-bot-7 closed 6 months ago
6
addLiquidity / removeLiquidity lack deadline check

#854 c4-bot-7 closed 6 months ago
4
Proposal quorum can be manipulated by malicious stakers

#853 c4-bot-3 closed 7 months ago
2
QA Report

#852 c4-bot-1 opened 7 months ago
3
There are wrong judgment conditions in function removeLiquidity，which can lead to liquidity token reserves below DUST

#851 c4-bot-3 closed 7 months ago
2
Possible lock of staked xSALT if maxUnstakeWeek is reduced

#850 c4-bot-10 closed 7 months ago
2
Upkeep may cause some pools to accumulate repetitive small losses of arbitrage profits to other pools

#849 c4-bot-7 opened 7 months ago
5
Inefficiencies in the Unstaking Process Diminish User Incentives for SALT Staking

#848 c4-bot-7 closed 6 months ago
5
Incomplete Whitelisted Pools State Boundary Implementation in Pools contract

#847 c4-bot-7 closed 6 months ago
4
Proposal quorum changes after proposals creation

#846 c4-bot-5 closed 7 months ago
2
DAO is unable to access USDS/DAI POL for its operations

#845 c4-bot-3 closed 6 months ago
4
Reusing a SALT that has already been used for voting can allow a malicious proposal to pass and compromise the protocol.

#844 c4-bot-9 opened 7 months ago
6
Funds continue to be frozen to DAO whenever upkeep.

#843 c4-bot-9 closed 7 months ago
3
Gas Optimizations

#842 c4-bot-5 opened 7 months ago
1
Users can use cooldown to avoid liquidation

#841 c4-bot-9 closed 7 months ago
2
Lack of Proposal deadlines gives advantage to the last voter

#840 c4-bot-4 closed 6 months ago
5
Incorrect call to `incrementBurnableUSDS` in `repayUSDS` will lead to loss of DAO POL

#839 c4-bot-5 closed 7 months ago
2
Impossible to change managed wallets with `proposeWallets` after first rejection

#838 c4-bot-6 opened 7 months ago
6
Lack of Liquidation Information for can cause loss of funds for the the Liquidizer

#837 c4-bot-3 closed 7 months ago
2
`ManagedWallet` won't work after a reject by calling `ManagedWallet.receive`

#836 c4-bot-4 closed 7 months ago
2
Proposals.sol: the owner of xSALT can prohibit ballot against him.

#835 c4-bot-6 closed 7 months ago
2
no access control on `burnTokensInContract `

#834 c4-bot-3 closed 7 months ago
1
`Pools._adjustReservesForSwap` calcluates amountOut incorrectly.

#833 c4-bot-3 closed 6 months ago
4
`Pools._addLiquidity` implementation is not correct.

#832 c4-bot-4 closed 6 months ago
13
In `DAO::formPOL()`, `DAO::withdrawPOL()`, `Liquidity::_dualZapInLiquidity()`, swaps are executed without slippage protection, invites sandwich attacks and will cause loss of funds

#831 c4-bot-1 closed 6 months ago
7
Possible revert due to division by zero error in Staking.calculateUnstake if unstakeRage is zero

#830 c4-bot-2 closed 7 months ago
2
Discrepancy in Excluded Countries as State Update is Unidirectional

#829 c4-bot-6 closed 7 months ago
2
Users can deposit unwhitelisted tokens into pools

#828 c4-bot-6 closed 6 months ago
4
approved ballots might be finalized in reversed order

#827 c4-bot-10 closed 6 months ago
5
No Slippage and Deadline Checks in Forming Protocol-Owned Liquidity

#826 c4-bot-10 closed 7 months ago
3
MISSING STALENESS CHECKS IN THE `latestChainlinkPrice:CoreChainlinkFeed.sol`

#825 c4-bot-10 closed 6 months ago
5
Changing Quorum Can Affect Proposal Success/Execution

#824 c4-bot-5 closed 6 months ago
11
`Proposals.proposeTokenWhitelisting` insufficient check causes token can be whitelist multiple-times

#823 c4-bot-3 closed 6 months ago
5
Typo can lead to one of the pool's reserves to reach 0 and skew the ratio

#822 c4-bot-3 closed 7 months ago
3
unsafe down casting from uint256 to uint128 can make user get less rewards

#821 c4-bot-3 closed 7 months ago
0
Frontrunning Liquidation can help a bad debtor keep his collateral for longer periods than desired

#820 c4-bot-8 closed 7 months ago
2
`Proposals.createConfirmationProposal` can be DOSed by mailicous user

#819 c4-bot-9 closed 6 months ago
4
DOS of two critical function responsible for token whitelisting can happen, because of the PoolsConfig::whitelistPool logic

#818 c4-bot-9 closed 7 months ago
2
user can claim same rewards multiple times and drain protocol of rewards and funds

#817 c4-bot-9 closed 7 months ago
0

Previous Next