search

code-423n4 / 2024-02-ai-arena-findings

4 stars 3 forks source link

Upgraded Q -> 2 from #1964 [1710738038251] #2068

Closed c4-judge closed 6 months ago

c4-judge commented 6 months ago

Judge has assessed an item in Issue #1964 as 2 risk. The relevant finding follows:

claimFighters() function allows users to claim a pre-determined number of fighters. It does so by minting NFTs via a loop. The length of the loop is determined by the total amount of NFTs to mint. Relevant code:

uint16 totalToMint = uint16(numToMint[0] + numToMint[1]); The potential overflow exists in this line of code. As both numToMint variables are of type uint8 if summation overflows type(uint8).max, the transaction will revert.

c4-judge commented 6 months ago

HickupHH3 marked the issue as duplicate of #1322

c4-judge commented 6 months ago

HickupHH3 marked the issue as satisfactory

c4-judge commented 6 months ago

HickupHH3 marked the issue as unsatisfactory: Invalid