search

code-423n4 / 2024-02-althea-liquid-infrastructure-findings

3 stars 1 forks source link

Use safeMint instead of mint for ERC721 #758

Closed c4-bot-9 closed 8 months ago

c4-bot-9 commented 9 months ago

Lines of code

https://github.com/code-423n4/2024-02-althea-liquid-infrastructure/blob/bd6ee47162368e1999a0a5b8b17b701347cf9a7d/liquid-infrastructure/contracts/LiquidInfrastructureERC20.sol#L310

Vulnerability details

Impact

ERC721Fee can not set fee when the NFT token ID value is more than type(uint128).max RC721Fee can not set fee when the NFT token ID value is more than type(uint128).max

Tools Used

manual

Recommended Mitigation Steps

Use safeMint instead of mint to check received address support for ERC721 implementation.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/ERC721.sol#L262

Assessed type

ERC721

c4-pre-sort commented 9 months ago

0xRobocop marked the issue as insufficient quality report

c4-pre-sort commented 9 months ago

0xRobocop marked the issue as primary issue

0xRobocop commented 9 months ago

Unsatisfactory

0xRobocop commented 9 months ago

Duping here all findings by warden since it is pure spam and pretty low quality.

c4-judge commented 8 months ago

0xA5DF marked the issue as unsatisfactory: Out of scope