search

code-423n4 / 2024-02-hydradx-findings

1 stars 0 forks source link

QA Report #203

Open c4-bot-2 opened 6 months ago

c4-bot-2 commented 6 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 6 months ago

0xRobocop marked the issue as insufficient quality report

c4-judge commented 6 months ago

OpenCoreCH marked the issue as grade-b

QiuhaoLi commented 5 months ago

Hi @OpenCoreCH, thanks for the review. The first Low issue stableswap: Attackers can prevent the first add_liquidity by transferring one token to the pool directly should be duplicated with #148:

  1. It pointed out the same problem: add one token to DoS add_liquidity.
  2. It also mentioned the same root cause: DoS happens in "calculate_shares" because there are not all non-zero in the initial_reserves.
  3. It pointed out that this issue can be mitigated by donating some dust tokens but that's an unexpected behavior for users.
OpenCoreCH commented 5 months ago

No longer applicable after downgrade of issue