M-11 MitigationConfirmed

[c4-bot-5]

Lines of code

Vulnerability details

C4 Issue

M-11: Protocol does not implement EIP712 correctly on multiple occasions

Mitigation

PR-2: properly implementing eip-712

All the suggested mitigations were implemented on the PR correctly:

• Use abi.encodePacked when calculating the rentalOrderTypeHash
• Apply keccak256(hook.extraData) when calculating _deriveHookHash()
• Add the missing data for the corresponding typehash (orderType, emittedExtraData, rentalWallet)

Ref: EIP-712

Conclusions

Successful Mitigation

[c4-judge]

gzeon-c4 marked the issue as satisfactory

[c4-judge]

gzeon-c4 marked the issue as confirmed for report