search

code-423n4 / 2024-02-renft-mitigation-findings

0 stars 0 forks source link

H-02 MitigationConfirmed #31

Open c4-bot-8 opened 5 months ago

c4-bot-8 commented 5 months ago

Lines of code

Vulnerability details

This vulnerability is successfully fixed. A rental safe owner can no longer set a fallback handler of his own because the guard prevents it from happening now.

https://github.com/re-nft/smart-contracts/blob/97e5753e5398da65d3d26735e9d6439c757720f5/src/policies/Guard.sol#L362C1-L367C14

            // Revert if the `setFallbackHandler` selector is specified.
            if (selector == gnosis_safe_set_fallback_handler_selector) {
                revert Errors.GuardPolicy_UnauthorizedSelector(
                    gnosis_safe_set_fallback_handler_selector
                );
            }
c4-judge commented 5 months ago

gzeon-c4 marked the issue as satisfactory