search

code-423n4 / 2024-02-spectra-findings

4 stars 2 forks source link

QA Report #121

Closed c4-bot-9 closed 8 months ago

c4-bot-9 commented 8 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 8 months ago

gzeon-c4 marked the issue as sufficient quality report

c4-judge commented 8 months ago

JustDravee changed the severity to 2 (Med Risk)

c4-judge commented 8 months ago

JustDravee changed the severity to QA (Quality Assurance)

c4-judge commented 8 months ago

JustDravee marked the issue as grade-a

c4-sponsor commented 8 months ago

yanisepfl (sponsor) disputed

yanisepfl commented 8 months ago

We have already disputed and provided a complete explanation as to why this is intended and not an issue. Short answer: Yes we use slightly different rates in deposit and previewDeposit methods in order to respect the standards that we wish to follow, but:

when going through the deposit() route the the ptRate will be rounded down, which means slightly more shares in favor of the user.

Yes the user receives slightly more shares than in the previewDeposit flow, but the auditor omitted or forgot that their worth in assets will also be impacted by the ptRate being rounded down. In particular, we did it so that the protocol is always favored.

c4-judge commented 8 months ago

JustDravee marked the issue as grade-c