search

code-423n4 / 2024-02-spectra-findings

4 stars 2 forks source link

QA Report #82

Closed c4-bot-2 closed 8 months ago

c4-bot-2 commented 8 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 8 months ago

gzeon-c4 marked the issue as sufficient quality report

c4-judge commented 8 months ago

JustDravee marked the issue as grade-a

c4-judge commented 8 months ago

JustDravee marked the issue as selected for report

JustDravee commented 8 months ago

1) L 2) L 3) L 4) Why? Invalid 5) Info, potentially invalid 6) Invalid

c4-sponsor commented 8 months ago

yanisepfl (sponsor) disputed

yanisepfl commented 8 months ago

1.

shares can be zero if the whole value has been used to service fees

True but in such a scenario reverting is intended. Note that in our code MAX_TOKENIZATION_FEE = 1e16; which means that the tokenization fee will never exceeds 1%.

2. We have already explained in another issue why this is intended. Short answer: _convertIBTsToSharesPreview method is only used in _previewDepositIBT.

3. Rounding up the amount of shares to be burnt to withdraw a given amount of assets is, as opposed to what is claimed, in favor of the protocol.

  1. We want to integrate as much 4626s as possible, what the auditor proposes is too restrictive.

  2. whenever the yield to be calculated would be zero the function reverts

False statement.

  1. Confusion of the auditor here, coming from the fact that the shares of the IBT 4626 vaults are the IBTs themselves.

Therefore all the reports here are wrong and we dispute the issue

c4-judge commented 8 months ago

JustDravee marked the issue as not selected for report

c4-judge commented 8 months ago

JustDravee marked the issue as grade-c