search

code-423n4 / 2024-02-tapioca-findings

1 stars 1 forks source link

Upgraded Q -> 2 from #184 [1712936233288] #188

Closed c4-judge closed 5 months ago

c4-judge commented 5 months ago

Judge has assessed an item in Issue #184 as 2 risk. The relevant finding follows:

Check is always true https://github.com/Tapioca-DAO/tap-token/blob/050e666142e61018dbfcba64d295f9c458c69700/contracts/governance/twTAP.sol#L301-L302

    if (_timestampToWeek(block.timestamp) > currentWeek()) revert AdvanceEpochFirst(); /// @audit QA for now

Mitigation https://github.com/Tapioca-DAO/tap-token/blob/050e666142e61018dbfcba64d295f9c458c69700/contracts/governance/twTAP.sol#L464-L465

    if (lastProcessedWeek != currentWeek()) revert AdvanceWeekFirst();
c4-judge commented 5 months ago

dmvt marked the issue as duplicate of #119

c4-judge commented 5 months ago

dmvt marked the issue as partial-50