Analysis - Githubissues

code-423n4 / 2024-02-wise-lending-findings

7 stars 5 forks source link

Analysis #267

Open c4-bot-2 opened 3 months ago

c4-bot-2 commented 3 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 3 months ago

GalloDaSballo marked the issue as sufficient quality report

c4-pre-sort commented 3 months ago

GalloDaSballo marked the issue as high quality report

c4-judge commented 3 months ago

trust1995 marked the issue as grade-b

blckhv commented 3 months ago

Hey @trust1995, Thanks for the fast judging process, I would like to ask why this analysis is marked as grade-b when it follows all the outlined judging criteria here.

There is no code functionality repeated
All Wise Lending parts described have recommendations
No template writing, without explicitly saying which part of the code they target
Codebase quality is evaluated
Potential weak points are explained, according to my understanding of the codebase

Will be happy to have this analysis re-reviewed, thanks!

trust1995 commented 3 months ago

Firstly, your analysis was good! Very few made it to A/B grade. What you can improve on is providing more actionable content - improvement points, high-depth insight and so on.

blckhv commented 3 months ago

Will definitely work on that, but still I think compared to other reports it stands slightly better, mainly for not using text from the contest's readme and one-fit-all text as well as information available in Solidity Metrics extension.

Slavchew commented 3 months ago

I might also add that in all the other 'grade b' analyses most of the text explains the code structure, code flows, and diagrams generated by vs code extensions, except ours and other 'grade a' ones where the emphasis is on recommendations and problems.

radeveth commented 3 months ago

Hey, @trust1995!

Yes, this analysis report is not the best, but compared to other grade b analysis reports, it is for grade a. The report contains only pros and valuable information about the protocol, emphasizing the recommendations and problems of the protocol instead of writing code structure, code flows and diagrams generated by vs code extensions that simply do not provide any value to the protocol.