search

code-423n4 / 2024-02-wise-lending-findings

11 stars 8 forks source link

QA Report #286

Open c4-bot-1 opened 6 months ago

c4-bot-1 commented 6 months ago

See the markdown file with the details of this report here.

c4-pre-sort commented 6 months ago

GalloDaSballo marked the issue as insufficient quality report

c4-pre-sort commented 6 months ago

GalloDaSballo marked the issue as grade-c

thenua3bhai commented 6 months ago

Hi @trust1995 Thanks for judging. I reuqest you to please re-evaluate this QA report since this contains 8 Lows and 10 NC findings. Most of them are valid. In which 5 Lows and 7NCs are unique from bot while some findings L-1, L-2, L-3 and N-1,N-3 and N-9 similar to bot but they covers only different instances which were missed by bot, So I included them here since fixing bot instances will not fix these. I also mentioned a note that they are missed by bot. So comparing with other grade-a or grade-b reports this also contains adequate amount of Lows and NCs to be qualified for grade-a or maybe grade-b based on quality evaluated.

I also cheked my low findings with current medium findings. L-06 can be upgraded to medium and can be duplicate of #245 since both are same findings covers smae instances talks about unchecked return value in TransferHelper::_safeTransferFrom() and otehr 2 instances also. Since inside them _callOptionalReturn is called but it's return value never checked which will execute txn even when this function returns false.

L-07 and L-08 are also significant to consider for fixing.

Thanks.

c4-judge commented 6 months ago

trust1995 marked the issue as grade-b