search

code-423n4 / 2024-03-coinbase-findings

1 stars 0 forks source link

QA Report #159

Closed c4-bot-9 closed 8 months ago

c4-bot-9 commented 8 months ago

See the markdown file with the details of this report here.

raymondfam commented 8 months ago

[Q-02]: That's a direct assignment. No calculation is entailed. [Q-05]: if (block.timestamp > withdrawRequest.expiry) is well in place.

[Q-07]: Gas saving no longer applicable in newer solidity version. [Q-08]: That's the standard practice in compliance to CEI. [Q-09]: This is going to make SafeTransferLib.safeTransferETH(entryPoint(), amount) revert with a missing second parameter. [Q-10]: internal is itself a visibility and already present in the function entailed. [Q-11]: If none of the first two if is true, the function would just revert at the end of its logic. [Q-12]: That's the intended design and no multisiq will be entailed. [Q-13]: See [Q-12]

Too much noise. Additionally, no instance links have been given leaving 4 possibly ambiguous L/NC. (Less than the standard 5 bar.)

c4-pre-sort commented 8 months ago

raymondfam marked the issue as insufficient quality report

c4-pre-sort commented 8 months ago

raymondfam marked the issue as grade-c